Merged
Conversation
Moved comboText function to chartmanger, adjusted call in BD accordingly, combotext calls a feedback color function in input handler, still needs lots of work to produce the desirted colors/effects
Color approach wasn't working, so I switched to particles, seems to be more effective. On hit, yellow particles will briefly emit from the note, the amount will change depending on quality of hit. Added CpuParticle2D nodes to each note in NoteChart. Still tweaking size/amount/speed of particles, will change name of the function from FeedbackColor to something more appropaite. Should also try to add something similar for when the combo bar is full too
Set up for particles on full combo bar, but it won't let me use override for process. not sure if my machine is just being dumb
Finally realized that I didn't need process, added the effect in NotePlcementBar. Basic effect, but it's something we can tweak easily
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Made hit particles separate class and scene, and inherit parent color Simplified particle emitting Tweaked textparticle to be more explosive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effects are basic, but figured it's something we should get into the build before playtesting